AnuragRaut08 commented on PR #22452:
URL: https://github.com/apache/datafusion/pull/22452#issuecomment-4643056390
Addressed the review feedback:
* Moved `try_to_proto` into the `impl PhysicalExpr` block so it overrides
the default implementation.
* Removed the centralized `DynamicFilter` serialization arm from
`to_proto.rs`; serialization is now handled expression-locally following the
pattern introduced in #21929.
* Verified that the DynamicFilter roundtrip tests continue to pass after the
refactor:
* `test_dynamic_filter_roundtrip_dedupe`
* `test_dynamic_filter_plan_roundtrip_dedupe`
* `test_dynamic_filter_expression_id_is_stable_between_serializations`
* additional DynamicFilter roundtrip coverage also passes.
The decode path (`from_parts` in `from_proto.rs`) is unchanged in this PR.
Ready for re-review. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
