AnuragRaut08 commented on PR #22452: URL: https://github.com/apache/datafusion/pull/22452#issuecomment-4671435348
Thanks for the review @adriangb . I've now moved `try_from_proto` to `DynamicFilterPhysicalExpr` and updated the `ExprType::DynamicFilter` path to use `PhysicalExprDecodeCtx`, matching the expression-local serialization/deserialization pattern used by other migrated physical expressions. Existing DynamicFilter roundtrip tests continue to pass. Ready for another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
