crm26 commented on PR #22542: URL: https://github.com/apache/datafusion/pull/22542#issuecomment-4644510785
Thanks for the review. Addressed both asks: dropped the intermediate `slice` (iterate `start..end` directly on `values`) and switched to `is_valid` per your suggestion. Also pre-emptively matched the empty-array semantics to the merged `array_product` sibling (#22703) — your "what's this behaviour based on?" question there applies here too. Empty → NULL now, matching PostgreSQL, DuckDB `list_sum`, and SQL Standard SUM-of-empty-set. SLT and PR body updated accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
