2010YOUY01 commented on PR #22816: URL: https://github.com/apache/datafusion/pull/22816#issuecomment-4646593960
Thanks for working on it! Assuming the assumption is correct, that `opt_filter` is indeed never used — I think it is better to remove it, even if this causes an API change and downstream implementations need to update. A misleading API makes it easier to introduce bugs. However, since this is a public API change, I suggest to proceed after getting a few more +1s. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
