jiengup commented on code in PR #1825: URL: https://github.com/apache/datafusion-ballista/pull/1825#discussion_r3373449470
########## ballista-cli/src/tui/app.rs: ########## Review Comment: I implement job config feature as a popup. It's more like `JobPlansPopup` and `JobStagesPopup` than `JobDetail` so it will be strange if we need to pre-load it (like add a flag field in `App` struct in order to decided if we need render a popup window). Any suggestion about this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
