jiengup commented on code in PR #1825:
URL:
https://github.com/apache/datafusion-ballista/pull/1825#discussion_r3373512667
##########
ballista-cli/src/tui/ui/footer.rs:
##########
@@ -46,6 +46,10 @@ pub(super) fn render_footer(f: &mut Frame, area: Rect, app:
&App) {
current_view_key_bindings.push(Span::from("[p] Physical
plan, "));
current_view_key_bindings.push(Span::from("[l] Logical
plan, "));
current_view_key_bindings.push(Span::from("[Esc] Close
popup, "));
+ } else if app.is_job_config_popup_open() {
+ current_view_key_bindings.push(Span::from("[↑↓] Navigate,
"));
+ current_view_key_bindings.push(Span::from("[/] Search
config, "));
+ current_view_key_bindings.push(Span::from("[Esc] Close
popup, "));
Review Comment:
I think the [code
here](https://github.com/apache/datafusion-ballista/pull/1825/changes/BASE..b47436070b985c1091c1f2daf4fa74cb78bcbde6#r3373506431)
already handle this correctly.
We can only see `[Esc] Quit edit mode,` in edit mode even at job config
popup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
