alamb commented on issue #22723: URL: https://github.com/apache/datafusion/issues/22723#issuecomment-4651736346
> [@2010YOUY01](https://github.com/2010YOUY01) thanks for the link to the policy, I was unaware. I agree enforcing stricter invariants in the test framework than in the documentation is a bad idea. I'll wait a bit to see if anyone else wants to respond, but otherwise I'll make a revert PR for all of it and close the related issues as "won't fix". Coralogix has a downstream workaround now that alleviates our need for memory tracking. I agree with @2010YOUY01 here -- trying to make DataFusion's memory model better by enforcing the desired invariants in SLT is probably not a good way to get a clear and coherent design -- we would probably left chasing down memory accounting discrepancies indefinitely So let's make a revert PR SOmething I am not quite sure about is if there is a bug in the current code (where the stated policy, however flawed, is not actually followed by the current code)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
