alamb commented on issue #22506: URL: https://github.com/apache/datafusion/issues/22506#issuecomment-4653070010
> The surface should be rare in practice because parameter-using clients (JDBC, libpq drivers, sqlx etc.) typically generate queries with one consistent type per placeholder. Well, even if they are rare, I think anyone affected would not be happy. I think it is also against the API policy we have https://datafusion.apache.org/contributor-guide/api-health.html#what-is-the-public-sql-api-and-what-is-a-breaking-sql-change I think we need to figure out what we are solving here For example, the error @cetra3 reports above doesn't seem to really be about parameter resolution. > Error during planning: Expected parameter of type Utf8, got Utf8View: Conflicting types for id $1 It seems to me like the issue is that the parameter value supplied (Utf8) wasn't the same as expected (Utf8View), even though there is a lossless cast that could convert the types. perhaps we just need a call to `ScalarValue::cast_to` in the right place when substituting parameters 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
