2010YOUY01 commented on code in PR #22824:
URL: https://github.com/apache/datafusion/pull/22824#discussion_r3377354531
##########
datafusion/core/tests/physical_optimizer/limited_distinct_aggregation.rs:
##########
@@ -36,10 +36,17 @@ use
datafusion_physical_expr_common::sort_expr::PhysicalSortExpr;
use datafusion_physical_plan::{
ExecutionPlan,
aggregates::{AggregateExec, AggregateMode},
- collect,
+ collect, displayable,
limit::{GlobalLimitExec, LocalLimitExec},
};
+#[derive(Debug)]
+struct AggregateRuntimeMetric {
Review Comment:
Thank you, makes sense to me. Addressed in
[f54bf19](https://github.com/apache/datafusion/pull/22824/commits/f54bf19362ed0830f172c7cda14d7441c6dd5f53)
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -3151,6 +3156,103 @@ mod tests {
Ok(())
}
+ #[tokio::test]
+ async fn limited_distinct_aggregate_uses_migrated_hash_streams() ->
Result<()> {
Review Comment:
[f54bf19](https://github.com/apache/datafusion/pull/22824/commits/f54bf19362ed0830f172c7cda14d7441c6dd5f53)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
