chakkk309 opened a new pull request, #22838:
URL: https://github.com/apache/datafusion/pull/22838

   ## Which issue does this PR close?
   
   - Closes #22421.
   
   ## Rationale for this change
   
   CaseExpr should own its protobuf serialization and deserialization through 
the PhysicalExpr try_to_proto / try_from_proto hooks, matching the migration 
pattern used by other physical expressions and avoiding the central downcast 
chain.
   
   ## What changes are included in this PR?
   
   - Adds CaseExpr::try_to_proto in the PhysicalExpr impl.
   - Adds CaseExpr::try_from_proto as an inherent proto constructor.
   - Routes physical expression decoding for CaseExpr through the new hook.
   - Removes the old CaseExpr serialization arm and its helper from 
datafusion-proto.
   - Adds direct hook tests covering encode, decode, wrong node variant, 
missing when/then children, and child encode/decode error propagation.
   
   ## Are these changes tested?
   
   Yes:
   
   - cargo fmt --all
   - cargo test -p datafusion-physical-expr --features proto case::tests::try_
   - cargo test -p datafusion-proto --test proto_integration
   - cargo clippy -p datafusion-physical-expr --features proto --tests -- -D 
warnings
   - cargo clippy -p datafusion-proto --test proto_integration -- -D warnings
   
   ## Are there any user-facing changes?
   
   No. This is an internal proto serialization refactor with the same wire 
format.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to