rluvaton commented on code in PR #22845:
URL: https://github.com/apache/datafusion/pull/22845#discussion_r3379905823
##########
datafusion/physical-expr-common/src/metrics/baseline.rs:
##########
@@ -68,6 +69,11 @@ pub struct BaselineMetrics {
/// Issue: <https://github.com/apache/datafusion/issues/16841>
output_bytes: Count,
+ /// Size of the largest batch output from this operator,
+ /// this can help detect skews in partitions,
+ /// or an exceedingly large batch which caused an error/spill.
Review Comment:
Please add note here that it suffer from the same problem as `output_bytes`
metric
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
