Rich-T-kid opened a new pull request, #22859:
URL: https://github.com/apache/datafusion/pull/22859
## Which issue does this PR close?
Works towards closing #21878
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #21878.
## Rationale for this change
There is currently no benchmarks that cover `GroupValueRow()` when
dictionary arrays are passed in. #22004 adds benchmarks for the single single
column case. This PR adds benchmarks for the multi column case
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Adds a new Criterion harness for GroupValues over multi-column
Dictionary<UInt64, Utf8> GROUP BY workloads, covering 4 and 8 group-by columns
across batch sizes of 8 KiB and 64 KiB rows. It tests four realistic
cardinalities (20, 100, 500, 1 000 distinct values) with per-column variance
introduced by sampling each column's distinct count from a ±5% window around
the target, so columns within the same batch have slightly different
cardinalities. Two benchmark variants are included — repeated intern+emit and a
partial-emit pattern that spills half the accumulated groups after each intern
— to stress both the steady-state and incremental-flush paths of the group
values implementation.
## Are these changes tested?
n/a
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
