paleolimbot commented on code in PR #22663:
URL: https://github.com/apache/datafusion/pull/22663#discussion_r3390827423
##########
datafusion/physical-expr/src/async_scalar_function.rs:
##########
@@ -211,6 +208,12 @@ impl PhysicalExpr for AsyncFuncExpr {
self.func.data_type(input_schema)
}
+ fn return_field(&self, _input_schema: &Schema) -> Result<FieldRef> {
+ Ok(Arc::new(
+ self.return_field.as_ref().clone().with_name(&self.name),
Review Comment:
I think in general there is a lot of confusion about whether or not the
name, metadata, nullability, are supposed to be propagated at any given time.
The existing code is all over the place so humans and their LLMs are, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
