github-actions[bot] commented on PR #22893: URL: https://github.com/apache/datafusion/pull/22893#issuecomment-4674501796
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-physical-plan v54.0.0 (current) Built [ 35.969s] (current) Parsing datafusion-physical-plan v54.0.0 (current) Parsed [ 0.127s] (current) Building datafusion-physical-plan v54.0.0 (baseline) Built [ 35.305s] (baseline) Parsing datafusion-physical-plan v54.0.0 (baseline) Parsed [ 0.123s] (baseline) Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.662s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_physical_plan::joins::join_hash_map::get_matched_indices_with_limit_offset now takes 8 parameters instead of 7, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:389 datafusion_physical_plan::joins::utils::update_hash now takes 9 parameters instead of 8, in /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/utils.rs:2113 --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_parameter_count_changed.ron Failed in: JoinHashMapType::get_matched_indices_with_limit_offset now takes 6 instead of 5 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:124 JoinHashMapType::get_matched_indices_with_limit_offset now takes 6 instead of 5 parameters, in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/joins/join_hash_map.rs:124 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 74.076s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
