neilconway commented on code in PR #22893:
URL: https://github.com/apache/datafusion/pull/22893#discussion_r3431181443


##########
datafusion/physical-plan/src/joins/hash_join/stream.rs:
##########
@@ -679,6 +686,7 @@ impl HashJoinStream {
                 // Precalculate hash values for fetched batch
                 let keys_values = 
evaluate_expressions_to_arrays(&self.on_right, &batch)?;
 
+                let mut valid_keys = None;

Review Comment:
   Yep that's better, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to