JarroVGIT commented on code in PR #1852:
URL:
https://github.com/apache/datafusion-ballista/pull/1852#discussion_r3393934499
##########
ballista/scheduler/src/state/aqe/planner.rs:
##########
@@ -151,7 +152,7 @@ impl AdaptivePlanner {
pub async fn try_new(
ctx: &SessionContext,
logical_plan: &LogicalPlan,
- job_name: String,
+ job_name: JobName,
Review Comment:
See #1859
##########
ballista/scheduler/src/state/aqe/planner.rs:
##########
@@ -359,12 +364,10 @@ impl AdaptivePlanner {
// that would arise if the rule walked the entire
residual
// plan in `default_optimizers()`.
let plan = CoalescePartitionsRule.optimize(plan,
config)?;
- BallistaAdapter::adapt_to_ballista(
- plan,
- self.job_name.as_str(),
- config,
- )
- .map(|w| (w.plan.stage_id(), w))
+ // adapt_to_ballista takes an job_id, we are passing a
job_name. Need to transform to fix compiler.
+ let job_id = self.job_name.clone().into_inner().into();
Review Comment:
See #1859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
