JarroVGIT commented on PR #1852:
URL:
https://github.com/apache/datafusion-ballista/pull/1852#issuecomment-4672593908
@milenkovicm I have removed `JobName` again.
@martin-g I saw your comments and started to fix a few, but also saw you
have resolved them all afterwards. I have made the following changes:
- Replace `&JobId::new("job-1")` with `&"job-1".into()`. It actually saves
another import in some files, which was a nice benefit.
- Replaced several `to_owned().into()` with `into()` where appropriate. I
remember contemplating if I should or should not implement `From<&str>`,
decided to implement it and then apparently did not use it (whoops).
There are a few comments in there with questions, where I am not sure how to
approach it best.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
