discord9 commented on code in PR #22837:
URL: https://github.com/apache/datafusion/pull/22837#discussion_r3393950459
##########
datafusion/expr-common/src/casts.rs:
##########
@@ -103,6 +103,35 @@ fn is_lossy_temporal_cast(from_type: &DataType, to_type:
&DataType) -> bool {
|| (is_date_type(to_type) && from_type.is_temporal())
}
+/// Returns true when casting a timestamp from `from_type` to `to_type` loses
Review Comment:
> Why is this specific to timestamps? It seems like any narrowing cast would
have the same problem for example cast(x as int) = 5 can't be unwrapped to `x =
5.0` for floats
was just trying to make this pr small since the last allow list one is too
large, considering adding a longer block list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
