kumarUjjawal opened a new pull request, #22903:
URL: https://github.com/apache/datafusion/pull/22903
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #22895.
## Rationale for this change
Join-key extraction can add helper projections and change a child plan's
output schema. Some parent nodes cache their schema, so after the child rewrite
they can still expose stale fields. Later projection pruning then uses the
stale schema and fails with missing-column errors.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
- Refresh a parent schema only when a rewritten child reports an actual
schema change.
- Re-check whether the plan has subqueries before each rule, so plans that
are decorrelated by earlier rules can use the in-place path in the same
optimizer pass.
- Add regression coverage for the reported struct-field join-key failures.
- Add a regression case for union output labels while union-to-filter
rewriting is enabled.
- Add a focused optimizer unit test for parent schema refresh after child
schema changes.
- Update one existing optimized-plan expectation. The new plan removes a
redundant dedup step; the surrounding semi joins already preserve distinctness.
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
Yes
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
