alamb commented on code in PR #22908: URL: https://github.com/apache/datafusion/pull/22908#discussion_r3397039210
########## datafusion/sqllogictest/test_files/variant_get.slt: ########## @@ -5,22 +5,32 @@ # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at - +# # http://www.apache.org/licenses/LICENSE-2.0 - +# # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. - -########## -## INSERT VALUES placeholder tests -########## - statement ok -CREATE TABLE placeholder_zero_insert(x BIGINT NULL); +CREATE TABLE json_data (id INT, json_str TEXT) AS VALUES Review Comment: this is pretty cool ########## datafusion/core/Cargo.toml: ########## @@ -42,6 +42,7 @@ workspace = true nested_expressions = ["datafusion-functions-nested"] # This feature is deprecated. Use the `nested_expressions` feature instead. array_expressions = ["nested_expressions"] +variant_expressions = ["datafusion-functions-variant"] Review Comment: see my comments on datafusion-json https://github.com/apache/datafusion/pull/21353#discussion_r3390550726 While appealing from a "no extra config" point of view, I think it is extremely important NOT to make these functions a new dependency of the core `datafusion` crate -- instead I think we should follow the model of `datafusion-functions-spark` -- that the dependency goes the other way (datafusion-functions-variatn --> datafusion) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
