andygrove opened a new pull request, #4628: URL: https://github.com/apache/datafusion-comet/pull/4628
## Which issue does this PR close? N/A. This is a documentation correction. ## Rationale for this change The Spark expression support reference (`expressions.md`) is maintained by hand, and several entries went stale after recent feature PRs enabled the expressions but did not flip the status in this page. EXPLAIN, the dispatcher, and users all read this table as the source of truth, so leaving these as `🔜 Planned` understates what Comet already accelerates. ## What changes are included in this PR? Marks five expressions as ✅ Supported to match the current code: * `dayname` / `monthname`: implemented as native Rust scalar functions and wired through the Spark 4.x expression shim in [#4544](https://github.com/apache/datafusion-comet/pull/4544). Noted as Spark 4.0+ since the `DayName` / `MonthName` classes only exist there. * `regexp_extract` / `regexp_extract_all` / `regexp_instr`: registered as `CometCodegenDispatch` serdes that route through the JVM codegen dispatcher in [#4239](https://github.com/apache/datafusion-comet/pull/4239), so they run inside the Comet pipeline with Spark-compatible results. The closely related `regexp_count` and `regexp_substr` remain `🔜` because they are not yet registered, and the higher-order `filter` remains `🔜` because `CometArrayFilter` still only supports the `array_compact` (`IsNotNull`) form. ## How are these changes tested? Documentation-only change. Each flipped entry was verified against the code: the native scalar functions in `comet_scalar_funcs.rs` and the Spark 4.x shim for `dayname` / `monthname`, and the `CometCodegenDispatch` registrations in `QueryPlanSerde.scala` for the regexp family. `expressions.md` is listed in `.prettierignore`, so no formatting step applies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
