fengys1996 commented on PR #22897: URL: https://github.com/apache/datafusion/pull/22897#issuecomment-4688063655
Thanks for your review. @Jefffrey > perhaps we can add this right now, but with expected error; that way when the upstream fix is merged and we upgrade to the arrow version we'll automatically know about the fix I tried adding the Date array-path SLT coverage by catching the panic as an expected error in https://github.com/apache/datafusion/pull/22897/changes/3f4ad71567c2756af22afe5c561bc1b3d91e2497. But the behavior is profile-dependent: debug panics, while release wraps and succeeds. It is not stable for CI, so I reverted it. > perhaps like this to reuse the validation logic from ensure_timestamp_in_bounds? Good suggestion, Done in https://github.com/apache/datafusion/pull/22897/changes/970d1aef264a12580a2679db4ee90f3f924d59e2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
