JarroVGIT commented on code in PR #22900:
URL: https://github.com/apache/datafusion/pull/22900#discussion_r3403141224
##########
datafusion/datasource-csv/src/source.rs:
##########
@@ -261,6 +262,10 @@ impl FileSource for CsvSource {
Ok(opener)
}
+ fn as_any(&self) -> &dyn Any {
Review Comment:
`as_any()` is not part of the `FileSource` trait.
##########
datafusion/datasource-csv/src/source.rs:
##########
@@ -411,6 +419,9 @@ impl FileOpener for CsvOpener {
let mut timer =
baseline_metrics.elapsed_compute().timer();
let result = reader.next();
timer.stop();
+ if let Some(Ok(ref batch)) = result {
Review Comment:
This addition and the addition in the next leg, will double count the output
rows, as the `FileStream` (where these recordbatches are eventually polled
through) also sets the output rows:
[mod.rs](https://github.com/sp-202/datafusion/blob/427bcabf59842db3d65596d4c70a9466dfc9f9f1/datafusion/datasource/src/file_stream/mod.rs#L126-L127)
I might be wrong though, please double check for yourself as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
