Jefffrey commented on code in PR #22655: URL: https://github.com/apache/datafusion/pull/22655#discussion_r3407156874
########## datafusion/sqllogictest/test_files/math.slt: ########## @@ -686,6 +686,22 @@ select gcd(-9223372036854775808, 0); query error DataFusion error: Arrow error: Compute error: Signed integer overflow in GCD\(0, \-9223372036854775808\) select gcd(0, -9223372036854775808); +# gcd decimal Review Comment: I think we're still missing cases for decimals like `1.23` (non whole numbers) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
