Jefffrey commented on code in PR #22655:
URL: https://github.com/apache/datafusion/pull/22655#discussion_r3408777910
##########
datafusion/sqllogictest/test_files/math.slt:
##########
@@ -686,6 +686,22 @@ select gcd(-9223372036854775808, 0);
query error DataFusion error: Arrow error: Compute error: Signed integer
overflow in GCD\(0, \-9223372036854775808\)
select gcd(0, -9223372036854775808);
+# gcd decimal
Review Comment:
I wanted to see a case where we calculate gcd on non-integers; the test case
you linked still operates on whole numbers since it cases to decimals with 0
scale
e.g. from postgres
```sql
postgres=# select gcd(15.3, 2.9);
gcd
-----
0.1
(1 row)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
