Xuanwo commented on code in PR #22951: URL: https://github.com/apache/datafusion/pull/22951#discussion_r3419166834
########## datafusion/ffi/src/session/mod.rs: ########## Review Comment: The downside is that `ConfigFileType::PARQUET` itself is currently gated behind `datafusion-common/parquet`, so `datafusion-ffi --no-default-features` cannot reference that enum variant at all. This PR still preserves the plain `table_options.parquet.*` values in no-default builds. The only value it cannot preserve without enabling the parquet feature is `current_format = PARQUET`, because that variant is compiled out upstream. Decoupling the enum variant from the parquet crate dependency would need a separate `datafusion-common` feature-boundary change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
