Xuanwo commented on code in PR #22951:
URL: https://github.com/apache/datafusion/pull/22951#discussion_r3419170131
##########
Cargo.toml:
##########
@@ -151,7 +151,7 @@ datafusion-physical-expr-adapter = { path =
"datafusion/physical-expr-adapter",
datafusion-physical-expr-common = { path = "datafusion/physical-expr-common",
version = "54.0.0", default-features = false }
datafusion-physical-optimizer = { path = "datafusion/physical-optimizer",
version = "54.0.0" }
datafusion-physical-plan = { path = "datafusion/physical-plan", version =
"54.0.0" }
-datafusion-proto = { path = "datafusion/proto", version = "54.0.0" }
+datafusion-proto = { path = "datafusion/proto", version = "54.0.0",
default-features = false }
Review Comment:
Yes, this is intentional. Cargo does not let a workspace member override an
inherited dependency from default features enabled to disabled. The workspace
dependency has to use `default-features = false`, and members that need the
previous behavior opt into `parquet` explicitly.
`datafusion-ffi` still preserves its previous default behavior through its
own default `parquet` feature, while downstream users can now opt out with
`default-features = false`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
