Phoenix500526 opened a new pull request, #23024:
URL: https://github.com/apache/datafusion/pull/23024
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #23008.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
`HashJoinStream::state_after_build_ready` relies on two *different* facts
about the collected build side:
- whether the build side physically has rows (`batch().num_rows()`)
- whether the hash map has any matchable entries (`map().is_empty()`)
These diverge under `NullEquality::NullEqualsNothing`: build rows whose join
key is NULL are omitted from the map, so the map can be empty while the build
side still has rows. Conflating the two was the source of the bug fixed in
#22893.
Today both checks are written inline as raw `batch().num_rows() == 0` /
`map().is_empty()`. Giving each a name on `JoinLeftData` makes the distinction
explicit at the API surface, so future call sites are harder to get wrong.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Add two helpers on `JoinLeftData`:
- `has_build_rows()` — build-side row presence
- `has_matchable_build_rows()` — matchable hash-map entry presence
- Update `state_after_build_ready` to use them instead of the raw checks.
Pure readability refactor — no behavior change.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Covered by the existing hash join tests; `cargo test -p
datafusion-physical-plan hash_join` passes (804 tests). Since this is a
readability-only refactor with no behavior change, no new tests are added.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
