Phoenix500526 commented on code in PR #23024:
URL: https://github.com/apache/datafusion/pull/23024#discussion_r3444994548
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -228,6 +228,25 @@ impl JoinLeftData {
&self.batch
}
+ /// Returns `true` if the build side physically contains rows.
+ ///
+ /// This is distinct from [`Self::has_matchable_build_rows`]: a build side
+ /// can hold rows while its hash map is empty (see that method).
+ pub(super) fn has_build_rows(&self) -> bool {
+ self.batch().num_rows() > 0
+ }
+
+ /// Returns `true` if the build-side hash map has any matchable entries.
+ ///
+ /// Under [`NullEquality::NullEqualsNothing`] build rows whose join key is
+ /// NULL are omitted from the map, so this can be `false` even when
+ /// [`Self::has_build_rows`] is `true`.
+ ///
+ /// [`NullEquality::NullEqualsNothing`]:
datafusion_common::NullEquality::NullEqualsNothing
Review Comment:
Removed
##########
datafusion/physical-plan/src/joins/hash_join/stream.rs:
##########
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
