comphead commented on code in PR #4678:
URL: https://github.com/apache/datafusion-comet/pull/4678#discussion_r3436945837
##########
spark/src/main/scala/org/apache/comet/serde/aggregates.scala:
##########
@@ -209,18 +186,20 @@ object CometAverage extends
CometAggregateExpressionSerde[Average] {
object CometSum extends CometAggregateExpressionSerde[Sum] {
+ override def getSupportLevel(expr: Sum): SupportLevel =
Review Comment:
we prob should have datatype supported on object level rather than on
AggSerde level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
