comphead commented on code in PR #4678:
URL: https://github.com/apache/datafusion-comet/pull/4678#discussion_r3436956517
##########
spark/src/main/scala/org/apache/comet/serde/aggregates.scala:
##########
@@ -638,6 +626,14 @@ object CometBloomFilterAggregate extends
CometAggregateExpressionSerde[BloomFilt
override def supportsMixedPartialFinal: Boolean = true
+ override def getSupportLevel(expr: BloomFilterAggregate): SupportLevel =
+ expr.child.dataType match {
+ case _: ByteType | _: ShortType | _: IntegerType | _: LongType | _:
StringType =>
+ Compatible()
+ case other =>
+ Unsupported(Some(s"Unsupported data type for bloom_filter_agg child:
$other"))
Review Comment:
Btw this message can unified and be on the base class, unless overriden.
Currently unsupported messages are not consistent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
