github-actions[bot] commented on PR #23051: URL: https://github.com/apache/datafusion/pull/23051#issuecomment-4753551339
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.0.0 (current) Built [ 104.445s] (current) Parsing datafusion v54.0.0 (current) Parsed [ 0.033s] (current) Building datafusion v54.0.0 (baseline) Built [ 103.566s] (baseline) Parsing datafusion v54.0.0 (baseline) Parsed [ 0.035s] (baseline) Checking datafusion v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.658s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 210.162s] datafusion Building datafusion-datasource v54.0.0 (current) Built [ 38.544s] (current) Parsing datafusion-datasource v54.0.0 (current) Parsed [ 0.032s] (current) Building datafusion-datasource v54.0.0 (baseline) Built [ 38.573s] (baseline) Parsing datafusion-datasource v54.0.0 (baseline) Parsed [ 0.032s] (baseline) Checking datafusion-datasource v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.239s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 78.429s] datafusion-datasource Building datafusion-ffi v54.0.0 (current) Built [ 60.358s] (current) Parsing datafusion-ffi v54.0.0 (current) Parsed [ 0.060s] (current) Building datafusion-ffi v54.0.0 (baseline) Built [ 62.099s] (baseline) Parsing datafusion-ffi v54.0.0 (baseline) Parsed [ 0.061s] (baseline) Checking datafusion-ffi v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.266s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 124.066s] datafusion-ffi Building datafusion-physical-optimizer v54.0.0 (current) Built [ 39.476s] (current) Parsing datafusion-physical-optimizer v54.0.0 (current) Parsed [ 0.021s] (current) Building datafusion-physical-optimizer v54.0.0 (baseline) Built [ 39.557s] (baseline) Parsing datafusion-physical-optimizer v54.0.0 (baseline) Parsed [ 0.021s] (baseline) Checking datafusion-physical-optimizer v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.117s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 80.197s] datafusion-physical-optimizer Building datafusion-physical-plan v54.0.0 (current) Built [ 37.501s] (current) Parsing datafusion-physical-plan v54.0.0 (current) Parsed [ 0.130s] (current) Building datafusion-physical-plan v54.0.0 (baseline) Built [ 37.368s] (baseline) Parsing datafusion-physical-plan v54.0.0 (baseline) Parsed [ 0.131s] (baseline) Checking datafusion-physical-plan v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.601s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/inherent_method_missing.ron Failed in: StatisticsArgs::compute_child_statistics, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/229699db0dd05312c530e37c144be4e87a6c9d34/datafusion/physical-plan/src/statistics.rs:119 StatisticsArgs::compute_child_statistics, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/229699db0dd05312c530e37c144be4e87a6c9d34/datafusion/physical-plan/src/statistics.rs:119 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_missing.ron Failed in: method statistics_with_args of trait ExecutionPlan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/229699db0dd05312c530e37c144be4e87a6c9d34/datafusion/physical-plan/src/execution_plan.rs:529 method statistics_with_args of trait ExecutionPlan, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/229699db0dd05312c530e37c144be4e87a6c9d34/datafusion/physical-plan/src/execution_plan.rs:529 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 76.814s] datafusion-physical-plan ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
