neilconway commented on PR #22921: URL: https://github.com/apache/datafusion/pull/22921#issuecomment-4753669758
#23044 fixed one of the CI failures, but there are several more CI failures induced by this PR under `force_hash_collisions`: https://github.com/apache/datafusion/actions/runs/27839118499/job/82393944968 ``` ---- approx_distinct::tests::utf8view_groups_short_string_hashed_consistently_across_batches stdout ---- thread 'approx_distinct::tests::utf8view_groups_short_string_hashed_consistently_across_batches' (50346) panicked at datafusion/functions-aggregate/src/approx_distinct.rs:1032:9: assertion `left == right` failed left: 1 right: 3 stack backtrace: 0: __rustc::rust_begin_unwind 1: core::panicking::panic_fmt 2: core::panicking::assert_failed_inner 3: core::panicking::assert_failed::<u64, u64> 4: datafusion_functions_aggregate::approx_distinct::tests::utf8view_groups_short_string_hashed_consistently_across_batches 5: datafusion_functions_aggregate::approx_distinct::tests::utf8view_groups_short_string_hashed_consistently_across_batches::{{closure}} 6: core::ops::function::FnOnce::call_once note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace. ---- approx_distinct::tests::update_batch_nullable_filter_excludes_null_filter_rows stdout ---- thread 'approx_distinct::tests::update_batch_nullable_filter_excludes_null_filter_rows' (50344) panicked at datafusion/functions-aggregate/src/approx_distinct.rs:1005:9: assertion `left == right` failed left: 1 right: 2 stack backtrace: 0: __rustc::rust_begin_unwind 1: core::panicking::panic_fmt 2: core::panicking::assert_failed_inner 3: core::panicking::assert_failed::<u64, u64> 4: datafusion_functions_aggregate::approx_distinct::tests::update_batch_nullable_filter_excludes_null_filter_rows 5: datafusion_functions_aggregate::approx_distinct::tests::update_batch_nullable_filter_excludes_null_filter_rows::{{closure}} 6: core::ops::function::FnOnce::call_once note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace. ---- approx_distinct::tests::utf8view_acc_split_batches_match_single_mixed_batch stdout ---- thread 'approx_distinct::tests::utf8view_acc_split_batches_match_single_mixed_batch' (50345) panicked at datafusion/functions-aggregate/src/approx_distinct.rs:1060:9: assertion `left == right` failed left: 1 right: 3 stack backtrace: 0: __rustc::rust_begin_unwind 1: core::panicking::panic_fmt 2: core::panicking::assert_failed_inner 3: core::panicking::assert_failed::<u64, u64> 4: datafusion_functions_aggregate::approx_distinct::tests::utf8view_acc_split_batches_match_single_mixed_batch 5: datafusion_functions_aggregate::approx_distinct::tests::utf8view_acc_split_batches_match_single_mixed_batch::{{closure}} 6: core::ops::function::FnOnce::call_once note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace. failures: approx_distinct::tests::update_batch_nullable_filter_excludes_null_filter_rows approx_distinct::tests::utf8view_acc_split_batches_match_single_mixed_batch approx_distinct::tests::utf8view_groups_short_string_hashed_consistently_across_batches ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
