huan233usc opened a new pull request, #23061: URL: https://github.com/apache/datafusion/pull/23061
## Which issue does this PR close? Follow-up to #22839 (stdin support in `datafusion-cli`), addressing post-merge review feedback from @alamb. No separate issue. ## Rationale for this change In the review of #22839, @alamb noted the `reuses_buffered_stdin_store` test would be clearer if it used the same API to create and re-fetch the object store: > this test would be clearer for me if it used the same API to create and recreate the object store -- aka `StdinUtils::get_or_create` rather than `StdinUtils::in_memory_object_store` The test built the buffered store via `StdinUtils::in_memory_object_store` but re-fetched it via `StdinUtils::get_or_create`, which obscured what "reuse" actually guarantees. ## What changes are included in this PR? Refactor `reuses_buffered_stdin_store` so the only `StdinUtils` API it exercises is `get_or_create`: - Seed the registry with a plain `InMemory` store. The genuine first stdin read happens inside `get_or_create` → `object_store`, which consumes the real process stdin and so cannot be driven from a unit test; the comment now explains this. - Assert via `Arc::ptr_eq` that `get_or_create` hands back that *exact* store rather than rebuilding it — a stronger and clearer statement of the reuse invariant than comparing bytes alone. Test-only change; no production behavior change. ## Are these changes tested? Yes — this is a test change. Verified locally: ``` cargo test -p datafusion-cli --lib object_storage::stdin ... test object_storage::stdin::tests::reuses_buffered_stdin_store ... ok test result: ok. 7 passed; 0 failed; 0 ignored; 0 measured; 62 filtered out ``` ## Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
