mkleen opened a new pull request, #23084: URL: https://github.com/apache/datafusion/pull/23084
## Which issue does this PR close? - Relates to #7C22989 but does not close it yet. More types are coming. ## Rationale for this change Float32 and Float64 don't implement `Hash` on their native type. Therefore, they can't use `NumericHLLAccumulator`. However they can be hashed generically via `create_hashes`, exactly like the string/binary types. ## What changes are included in this PR? See above. ## Are these changes tested? Yes, for grouped and non-grouped as part of approx_distinct.rst and aggregate.slt ## Are there any user-facing changes? Yes, but no breaking changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
