2010YOUY01 commented on PR #23084: URL: https://github.com/apache/datafusion/pull/23084#issuecomment-4784981470
Just to make sure I have the same understanding: is the concern that it is ambiguous whether nearly contiguous float values should be treated as distinct? For example: ```sql -- Should these be treated as distinct or equal? 3.141590, 3.141591, 3.141592 ``` I think the +-0.0 corner cases are not the key issue here, since they only make the result differ by a small constant and can also be special-cased. I think it is still valuable to add a comment, or improve the error message, to explain why `approx_distinct` does not support float types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
