alamb commented on code in PR #23140:
URL: https://github.com/apache/datafusion/pull/23140#discussion_r3470268225
##########
datafusion/ffi/src/physical_expr/metrics.rs:
##########
@@ -147,6 +147,10 @@ pub enum FFI_MetricValue {
name: SString,
gauge: u64,
},
+ PeakMemoryUsage {
Review Comment:
I think this enum needs to go at the end of the enum, not the middle, per
https://github.com/apache/datafusion/blob/833a91ad247e94d3af0e8a9ebf78ecf1d15ae5c8/datafusion/ffi/src/physical_expr/metrics.rs#L27-L28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
