Dandandan commented on PR #23162: URL: https://github.com/apache/datafusion/pull/23162#issuecomment-4796192644
> 1. bounds-checked the underlying `ScalarBuffer` twice. > 2. `maybe_poll_stream` was called on **every** output row, even though it is a > no-op whenever the winner's cursor is still live (the common case). The bounds-check reduction comes from remembering the previous version. > We can also potentially start investigating if unsafe would help here 🤔 (as a follow on PR) Yes - I think it would probably need modifying/replacing `CursorValues` to be more batch-aware (instead of per row). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
