kosiew commented on code in PR #23038:
URL: https://github.com/apache/datafusion/pull/23038#discussion_r3472325105
##########
datafusion/core/tests/user_defined/user_defined_aggregates.rs:
##########
@@ -103,6 +103,55 @@ async fn test_udaf() {
assert!(!test_state.retract_batch());
}
+#[tokio::test]
+async fn test_zero_argument_udaf() {
Review Comment:
Nice regression coverage here. Since `SessionContext::new()` uses the
default `datafusion.execution.enable_migration_aggregate=true`, this already
exercises the migrated aggregate path when the preconditions are met.
Could we add a small paired variant with
`datafusion.execution.enable_migration_aggregate=false` as well? That would
help keep the fallback `GroupedHashAggregateStream` path covered until the
migration flag is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
