ametel01 commented on code in PR #23038:
URL: https://github.com/apache/datafusion/pull/23038#discussion_r3487044070
##########
datafusion/common/src/hash_utils.rs:
##########
@@ -1852,6 +1852,8 @@ mod tests {
assert_eq!(hashes1, hashes2);
}
+ // Tests actual values of hashes, which are different if forcing collisions
+ #[cfg(not(feature = "force_hash_collisions"))]
Review Comment:
Thanks, good catch. I misunderstood this as still needing a guard, but the
test already has the cfg now. I’ll remove the redundant lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
