mkleen opened a new pull request, #23190: URL: https://github.com/apache/datafusion/pull/23190
## Which issue does this PR close? - Relates to https://github.com/apache/datafusion/issues/22989 but does not close it. More types are coming. ## Rationale for this change - Support Decimal type for `approx_distinct` - Decimal128 and Decimal256 can be directly supported by NumericHLLAccumulator and HllGroupsAccumulator ## What changes are included in this PR? - Enable NumericHLLAccumulator and HllGroupsAccumulator to support Decimal128 and Decimal256. - Tests for the non-grouped and grouped path as part of approx_distinct.rst and aggregate.slt. - Benchmarks for completeness ## Are these changes tested? Yes ## Are there any user-facing changes? Yes, approx_distinct supports now Decimal but no breaking changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
