Jefffrey commented on PR #23190: URL: https://github.com/apache/datafusion/pull/23190#issuecomment-4807189756
i dont think we should base support only on sql type mapping; for example this could be called via dataframe api, or if sql has arrow_cast, etc. `count` does support it via the generic catchall, but i think its just an oversight that decimal32/decimal64 dont have specialized paths since they were types added later (compared to decimal128/decimal256) https://github.com/apache/datafusion/blob/ff677c4a8b6bc098d00fba05a817619b08031809/datafusion/functions-aggregate/src/count.rs#L262-L266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
