viirya opened a new pull request, #1613: URL: https://github.com/apache/datafusion-python/pull/1613
# Which issue does this PR close? No separate issue filed; this is a small portability fix to the release verification script. # Rationale for this change The SNAPSHOT-version guard in `verify-release-candidate.sh` runs: ```sh if ( find -iname 'Cargo.toml' | xargs grep SNAPSHOT ); then ``` `find` is invoked without a starting path. GNU find (Linux) tolerates this and treats the current directory as the start, but BSD find (macOS) rejects it: ``` find: illegal option -- i ``` When that happens, `find` prints the usage error and produces no output, so the piped `xargs grep SNAPSHOT` receives nothing and exits non-zero. The `if (...)` therefore evaluates false and the script continues — meaning **the SNAPSHOT check is silently skipped on macOS** rather than actually running. A release verifier on macOS would get a passing run without this safety check ever executing. This surfaced while verifying the 54.0.0 RC on macOS. # What changes are included in this PR? Add an explicit `.` starting path: ```sh if ( find . -iname 'Cargo.toml' | xargs grep SNAPSHOT ); then ``` This is accepted by both GNU and BSD find, so the SNAPSHOT check runs correctly on Linux and macOS. # Are there any user-facing changes? No. This only affects the release-candidate verification script used by maintainers. This pull request and its description were written by Isaac. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
