2010YOUY01 commented on PR #23184: URL: https://github.com/apache/datafusion/pull/23184#issuecomment-4828220752
> After thinking about it for a bit I would prefer adding private helpers for each operator and then have general satisfaction for `RangePartitioning` once a good amount of operators are supported. Let me know what you think 😄 Thank you for the extra context! This approach makes sense if it's easier to implement. I think we should start with aggregation first, since single-input cases are simpler. Two-input/co-partitioned operators are trickier. For example, when a hash join requires its inputs to be [HashPartitioned(left_key), HashPartitioned(right_key)], it's really enforcing the co-partitioning property we're discussing here. We'll need to figure out how to incrementally migrate that to the new API to avoid duplicated implementations in the long term. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
