gene-bordegaray commented on PR #23184:
URL: https://github.com/apache/datafusion/pull/23184#issuecomment-4897384414
@stuhood @2010YOUY01 @gabotechs
I have explored this idea:
> ```rust
> // Before
> fn required_input_distribution(&self) -> Vec<Distribution> {
> vec![Distribution::UnspecifiedDistribution; self.children().len()]
> }
> ```
>
> ```rust
> // After
> pub struct RequiredInputDistributions {
> pub per_child: Vec<Distribution>,
> pub cross_child: Vec<CrossChildDistribution>,
> }
>
> trait ExecutionPlan {
> fn required_input_distributions(&self) -> RequiredInputDistributions {
> ...
> }
> }
> ```
I implemented this idea through `RequiredInputDistributions` in
`distribution_requirements.rs` I am not done but wanted to flesh out this rough
draft just to get feedback at a high level if you guys think this is worth
purusing in this PR 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
