andygrove commented on issue #4500:
URL: 
https://github.com/apache/datafusion-comet/issues/4500#issuecomment-4835748195

   **Item #7 (`signum` rejects interval inputs) — investigated; no live defect, 
folded into #4756.**
   
   Probed on Spark 3.5: `signum(double)` and `signum(int)` run natively and 
match Spark; day-time / year-month interval inputs **fall back gracefully** 
(intervals do not serialize), so there is no runtime error today.
   
   Like `greatest` / `least` (item #4), this only becomes relevant once the 
in-flight native interval-support PRs land, at which point `signum(interval)` 
will serialize and reach the native UDF (which currently handles only double). 
Added to #4756 as a deferred item: once intervals serialize, either extend the 
native `signum` path to take the sign of the interval's underlying integer 
representation (months / micros) or add an explicit `getSupportLevel` gate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to