andygrove commented on issue #4500: URL: https://github.com/apache/datafusion-comet/issues/4500#issuecomment-4835814598
## Closing summary All seven follow-up items have been investigated. None turned out to be a true correctness defect; closing the tracker accordingly. Each item was probed empirically (Comet vs Spark, native-vs-fallback) before reaching a conclusion. | Item | Outcome | | --- | --- | | 1. Lift `arithmetic.scala` `convert`-time fallbacks into `getSupportLevel` | Already done by #4674 (and #4615 for `try_mod`). The one residual, `CometUnaryMinus`, is addressed in #4759. | | 2. `UnaryPositive` serde on Spark 3.4 / 3.5 | Non-issue: `RemoveDispensableExpressions` removes `UnaryPositive` before serde on all supported versions, so `+col` projections already stay native. | | 3. `hex` / `unhex` collation | Non-issue: `hex` output is collation-invariant (`0-9A-F`); `unhex` returns `BinaryType`. Any collation-aware downstream op already falls back. | | 4. `greatest` / `least` input gating | No live defect (intervals/collated strings fall back gracefully; arrays/structs/NaN run natively and match Spark). Scalar-only gating would regress working cases. Deferred to #4756. | | 5. `ceil` / `floor` with scale (RoundCeil/RoundFloor) | Not a defect (falls back to Spark). True-native support needs CEILING/FLOOR modes added to `spark_round` (currently HALF_UP only). | | 6. `BRound` (HALF_EVEN) | Not a defect (correct via codegen dispatcher). True-native support needs HALF_EVEN in `spark_round`. | | 7. `signum` interval inputs | No live defect (intervals fall back gracefully). Deferred to #4756, to be handled when native interval support lands. | ### Follow-ups carried forward - #4759: complete item 1 for `CometUnaryMinus`. - #4756: revisit `greatest` / `least` and `signum` interval handling once native interval support lands, plus regression tests. - Items 5 / 6 (native rounding modes in `spark_round`) remain available as future enhancements; details captured in the comments above. Closing as there are no true correctness issues to track here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
