stuhood commented on PR #23231:
URL: https://github.com/apache/datafusion/pull/23231#issuecomment-4859082090

   > > But the choice to introduce Range partitioning would be a _logical_ 
decision, right? So, while I agree that changing logical optimizers to request 
Range would take a lot of thought and design, implementing the physical side 
(this PR) doesn't seem to be blocked on that? Or are you concerned that the API 
might still shift, or that it won't have enough test-coverage?
   > 
   > @stuhood I am most concerned with implementing physical layer behavior 
before having a real use for it that we can represent. What would the use case 
of being able to repartiution on range right now be? Do you have a use case 
where you would like to phsyically insert a repartition on range? maybe this is 
a good place to start the conversation on where and how this should be decided 🤔
   
   Understood.
   
   Yea, I don't feel strongly about it either way... but I don't really love 
the idea of leaving in physical paths that would panic if actually used. Even 
if the DF repository itself does not contain optimizer rules which introduce 
Range, I could imagine consuming repos attempting to introduce it, only to have 
it fail? But perhaps the DF project would prefer those folks to then come and 
talk about their use cases, to see whether they could be upstreamed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to