paleolimbot commented on code in PR #23169:
URL: https://github.com/apache/datafusion/pull/23169#discussion_r3509329109
##########
datafusion/physical-expr/src/expressions/cast.rs:
##########
@@ -127,6 +136,29 @@ impl CastExpr {
expr,
target_field,
cast_options: cast_options.unwrap_or(DEFAULT_CAST_OPTIONS),
+ preserve_source_metadata: true,
+ }
+ }
+
+ /// Create a new `CastExpr` with an explicit target `FieldRef`, using the
Review Comment:
The physical cast changes let me remove this flag, which I think was kind of
ugly anyway. The previous constructors were restored (although maybe we want to
make them better).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
