Jefffrey commented on code in PR #22905:
URL: https://github.com/apache/datafusion/pull/22905#discussion_r3524552592
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -1831,6 +1869,57 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_coercible_dictionary_preserves_encoding() -> Result<()> {
Review Comment:
Thanks for checking this; I'm a little worried because of the discrepancy
here now; is it a big task to try align them? Though we might need to check the
UDFs of existing functions that use a non-native typesignatureclass in case
they already knew this assumption and had dictionary paths 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
